Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic pygame.typing unit test, remove problematic TypeAlias usage #3150

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Add basic pygame.typing unit test, remove problematic TypeAlias usage #3150

merged 2 commits into from
Oct 12, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Oct 6, 2024

To catch issues like #3149

@ankith26 ankith26 requested a review from a team as a code owner October 6, 2024 20:22
@damusss damusss added tests tests (module) typing pygame.typing labels Oct 6, 2024
@damusss damusss added this to the 2.5.2 milestone Oct 6, 2024
damusss
damusss approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. LGTM!

@ankith26
Copy link
Member Author

I have implemented a commit fixing the issue in this PR.

For now, the best fix seems to be reverting the TypeAlias changes entirely. And when our minimum supported python version becomes 3.12 (which should about 3 years from now), we can consider using the new type keyword and the other fancy new typing stuff.

@ankith26 ankith26 linked an issue Oct 10, 2024 that may be closed by this pull request
How to fix the recent TypeAlias addition #3149
Closed
damusss
damusss approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Still looking good to me

@ankith26 ankith26 changed the title Add basic pygame.typing unit test Add basic pygame.typing unit test, remove problematic TypeAlias usage Oct 11, 2024
Starbuck5
Starbuck5 approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ankith26 ankith26 merged commit dd3df52 into main Oct 12, 2024
27 checks passed
@ankith26 ankith26 deleted the ankith26-typing-test branch October 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
tests tests (module) typing pygame.typing
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

How to fix the recent TypeAlias addition
3 participants
@ankith26 @Starbuck5 @damusss